proxy icon indicating copy to clipboard operation
proxy copied to clipboard

WiP: detect downstream first in tcp stream

Open lambdai opened this issue 3 years ago • 6 comments

Signed-off-by: Yuchen Dai [email protected]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

lambdai avatar Apr 10 '21 22:04 lambdai

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

istio-testing avatar Apr 10 '21 22:04 istio-testing

@bianpengyuan @douglas-reid we want to know how many users use server first protocol. How do we collecting info? We may not need to in perpetuity.

mandarjog avatar Apr 11 '21 05:04 mandarjog

Through TCP log labels?

bianpengyuan avatar Apr 11 '21 23:04 bianpengyuan

Through TCP log labels?

@bianpengyuan @douglas-reid Can you take over the rest? It's unclear to me how we'd like to export the metric. TBH I don't have the context if the detection code is expected to live in SD wasm filter.

lambdai avatar Apr 12 '21 17:04 lambdai

@kyessenov can you look at this, possible take it over?

mandarjog avatar Apr 22 '21 00:04 mandarjog

We technically already record that (connection open with sent > 0 and received = 0). But it needs to hit the timer at the right time.

kyessenov avatar Apr 22 '21 01:04 kyessenov

outdated

zirain avatar Oct 27 '22 06:10 zirain