proxy icon indicating copy to clipboard operation
proxy copied to clipboard

authn: revised request authenticator

Open Shikugawa opened this issue 3 years ago • 2 comments

What this PR does / why we need it: This is a part of replacement of authn wasm implementation. It is using revised request authentication API. https://github.com/istio/api/pull/1536 #2800 is too large and hard to review all codes so that I split all of authn wasm implementation.

Shikugawa avatar Jul 28 '20 14:07 Shikugawa

@Shikugawa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Nov 08 '20 19:11 istio-testing

Splitting the filter into multiple is fine with me.

One thing to note is that we were trying to combine multiple Wasm modules into one big fat module for performance reasons. So it might end up being one module in the end.

On Fri, Nov 13, 2020 at 8:44 PM Rei Shimizu [email protected] wrote:

@kyessenov https://github.com/kyessenov Discussed with @istio/wg-security-maintainers https://github.com/orgs/istio/teams/wg-security-maintainers, we should revise authn filter with some of components, not monorith authn filter. I shared design doc of that. But there is no consensus with googlers. Can you review it and add some comments? https://docs.google.com/document/d/1JCVR3IoHzuvIvl2Qrep785eNLGOVdwZ3Ha2rrsM-K5w

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/istio/proxy/pull/2952#issuecomment-727143987, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIYRRXOVTUR5BTZFOUAHLLSPYDJHANCNFSM4PKTIEJQ .

kyessenov avatar Nov 16 '20 17:11 kyessenov

outdated

zirain avatar Oct 27 '22 06:10 zirain