pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Published 20 hours ago • verified publisher icon istio

Add vendor_version for build info

Open shamsher31 opened this issue 3 years ago • 4 comments

To fix https://github.com/istio/istio/issues/33421

shamsher31 avatar Jun 15 '21 11:06 shamsher31

😊 Welcome @shamsher31! This is either your first contribution to the Istio pkg repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Jun 15 '21 11:06 istio-policy-bot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

istio-testing avatar Jun 15 '21 11:06 istio-testing

@shamsher31 in the build if VERSION is set it is used to link stamp binaries. We will now set that VERsIOn to the full version including Google specific extensions. Like 1.10.2-asm.5

mandarjog avatar Jun 15 '21 15:06 mandarjog

@shamsher31: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Oct 10 '22 22:10 istio-testing