operator icon indicating copy to clipboard operation
operator copied to clipboard

add in kustomization in root directory to allow for ease of use with …

Open Kampe opened this issue 3 years ago • 4 comments

…kustomize remote base

This allows people to utilize this repository as a base and patch overlays on top.

ie

Bases:
- github.com/istio/operator

Kampe avatar Sep 02 '20 19:09 Kampe

This repo is inactive and out of date - see istio/istio/manifests instead.

ostromart avatar Sep 02 '20 21:09 ostromart

Interesting, thats sad because I don't think this is useful all in one place - kustomize remote base assumes the root dir, of which in the istio proper repository, I don't believe they're even present there anymore and unfortunately this would live in the root of the repo and there's no logic there around the operator aside from mention in the .MD

Kampe avatar Sep 02 '20 22:09 Kampe

Does kustomize require a root dir? I have used kustomize build " https://github.com/kubernetes-sigs/service-apis/config/crd which isn't the root unless I am understanding incorrectly.

On Thu, Sep 10, 2020 at 9:54 AM Nick Kampe [email protected] wrote:

Interesting, thats sad because I don't think this is useful all in one place - kustomize remote base assumes the root dir, of which in the istio proper repository, I don't believe they're even present there anymore and unfortunately this would live in the root of the repo and there's no logic there around the operator aside from mention in the .MD

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/istio/operator/pull/780#issuecomment-686060515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYGXNGJ4PQUBRR7LCMYD3SFEACTANCNFSM4QTVKV3Q .

howardjohn avatar Sep 10 '20 17:09 howardjohn

You can reference resources by the raw files in a kustomization.yaml - however I'm pretty sure the remote base kustomization requires a kustomization to live in the root, and point to either resources itself, or another kustomization.yaml in a different directory in which points to the resources.

Edit: seems your are right and you can specify a URI (invalid to github) and it'll traverse the tree to the kustomize assets, do wonder if this is a feature or a bug.

Kampe avatar Sep 10 '20 22:09 Kampe