operator icon indicating copy to clipboard operation
operator copied to clipboard

add test for manager.

Open morvencao opened this issue 4 years ago • 4 comments

morvencao avatar Oct 17 '19 06:10 morvencao

@sdake @geeknoid I have added test for the controller and manager which needs kubebuilder binaries to get started, would you help to add kubebuilder binaries to the build-tools image.

The test is import because it can prevent the API changes that breaks the controller.

In my local env, I'm using kubebuilder v1.0.8 and everything is OK:

root@mcdev1:~/go/src/istio.io/operator# kubebuilder version
Version: version.Version{KubeBuilderVersion:"1.0.8", KubernetesVendor:"1.13.1", GitCommit:"1adf50ed107f5042d7472ba5ab50d5e1d357169d", BuildDate:"2019-01-25T23:14:29Z", GoOs:"unknown", GoArch:"unknown"}

morvencao avatar Oct 17 '19 06:10 morvencao

/retest

elfinhe avatar Dec 27 '19 17:12 elfinhe

@morvencao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test_operator ad7d152956fd7b94f5633e9a2220d270d1a6abc5 link /test test_operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Dec 27 '19 17:12 istio-testing

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 12 '20 17:02 istio-testing