operator icon indicating copy to clipboard operation
operator copied to clipboard

update controller version.

Open morvencao opened this issue 4 years ago • 6 comments

update controller version.

morvencao avatar Sep 29 '19 05:09 morvencao

/hold

morvencao avatar Oct 01 '19 02:10 morvencao

@morvencao can you address @ostromart's comment and update the version.yaml reference so we can get this merged?

I'm hoping folks can start test controller (on server side) after this.

linsun avatar Oct 09 '19 01:10 linsun

@morvencao is this PR still valid? If so, can you rebase, if not can you abandon?

Cheers -steve

sdake avatar Oct 22 '19 06:10 sdake

I minimized the change to only update the controller version, other changes has been in the master branch, PTAL @sdake

This PR is not mandatory for 1.4 release, we can merge this after 1.4 is released.

morvencao avatar Oct 22 '19 06:10 morvencao

@morvencao: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
e2e_operator 034ef25b0a4e56c64e6896a80cfed1211b1a70b7 link /test e2e_operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Oct 22 '19 06:10 istio-testing

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2019-10-22. It will be closed on 2019-12-06 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar Nov 22 '19 00:11 istio-policy-bot