old_mixer_repo icon indicating copy to clipboard operation
old_mixer_repo copied to clipboard

Published 20 hours ago • verified publisher icon istio

Fix relative imports in //BUILD.api

Open mandarjog opened this issue 8 years ago • 4 comments 

go_proto_library(
    name = "istio/config/v1",
    imports = [
        "../../external/com_github_google_protobuf/src"

prior comments:

geeknoid: Definitely not the right way to do this. I think the importmap feature is what you need here.
douglas-reid: importmap isn't needed for "well-known" protos. but you do need to specify where to find the sources for imports.
geeknoid: This can't be the right way to find these files. This is assuming the structure of the blaze output directories.

mandarjog avatar Dec 22 '16 18:12 mandarjog

It most definitely exploits knowledge of bazel's build structure to accomplish its goal. I'll take another look at some point, but I believe when setting this up I tried the "obvious" workarounds and this was the only way that seemed to work.

douglas-reid avatar Dec 22 '16 18:12 douglas-reid

BTW, there is a PR that is out (and has been for awhile) to the pubref repo that would fix this issue. Perhaps we should start voting for its inclusion.

douglas-reid avatar Sep 26 '17 18:09 douglas-reid

How are we doing on this front? Any chance this will be addressed in 0.3? If not, let's just move the item to a different milestone.

geeknoid avatar Oct 24 '17 20:10 geeknoid

no changes recently. although, any changes to the repo structure for the project may alter the impact of this issue.

douglas-reid avatar Oct 24 '17 20:10 douglas-reid