istio icon indicating copy to clipboard operation
istio copied to clipboard

group manifestSet contents by component type

Open ilrudie opened this issue 1 year ago • 4 comments

Please provide a description of this PR:

fixes https://github.com/istio/istio/issues/53875

ilrudie avatar Nov 13 '24 15:11 ilrudie

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

istio-testing avatar Nov 13 '24 15:11 istio-testing

I believe we have tests that exercise this code path, maybe we can add one with multiple gateways

howardjohn avatar Nov 14 '24 16:11 howardjohn

100% agree John, I left it in draft while I figure out the best way to test this to ensure we don't regress

ilrudie avatar Nov 14 '24 16:11 ilrudie

/retest

ilrudie avatar Nov 15 '24 17:11 ilrudie

In response to a cherrypick label: new pull request created: #53930

istio-testing avatar Nov 18 '24 17:11 istio-testing