istio icon indicating copy to clipboard operation
istio copied to clipboard

autoregistration: fix xdsNode locality bug

Open dwj300 opened this issue 1 year ago • 2 comments

Please provide a description of this PR: Fixes https://github.com/istio/istio/issues/51800.

dwj300 avatar Jun 30 '24 20:06 dwj300

😊 Welcome @dwj300! This is either your first contribution to the Istio istio repo, or it's been a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Jun 30 '24 20:06 istio-policy-bot

Hi @dwj300. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

istio-testing avatar Jun 30 '24 20:06 istio-testing

@hzxuzhonghu Thanks for the quick review! Can we get this cherry-picked as well?

dwj300 avatar Jul 02 '24 22:07 dwj300

/cherry-pick release-1.21

dhawton avatar Jul 23 '24 15:07 dhawton

/cherry-pick release-1.22

dhawton avatar Jul 23 '24 15:07 dhawton

@dhawton: new pull request created: #52265

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

istio-testing avatar Jul 23 '24 15:07 istio-testing

@dhawton: new pull request created: #52266

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

istio-testing avatar Jul 23 '24 15:07 istio-testing