istio icon indicating copy to clipboard operation
istio copied to clipboard
verified publisher icon istio

gatewayapi: fix buildHTTPVirtualServices match order

Open zirain opened this issue 1 year ago • 2 comments

Please provide a description of this PR:

resubmit https://github.com/istio/istio/pull/50109

zirain avatar May 24 '24 07:05 zirain

What has changed from the first time? Can you give some context?

howardjohn avatar May 24 '24 15:05 howardjohn

What has changed from the first time? Can you give some context?

nothing was changing, I cannot reuse last PR because of rebase/force push, you should put a request change to hold this first.

zirain avatar May 24 '24 15:05 zirain

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2024-05-24. It will be closed on 2024-07-08 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar Jun 24 '24 05:06 istio-policy-bot

Thanks @howardjohn for explain the API spec, let me close this first.

TBH, I'm not sure is it a good idea to change the match order from Exact/Prefix/Regex to Exact/Regex/Prefix.

zirain avatar Jun 24 '24 19:06 zirain