istio
Deprecation warnings for downstream_connections
2024-02-22T15:04:15.263650Z warning envoy main external/envoy/source/server/server.cc:923 There is no configured limit to the number of allowed active downstream connections. Configure a limit in `envoy.resource_monitors.downstream_connections` resource monitor. thread=20
2024-02-22T15:04:15.264806Z warning envoy main external/envoy/source/server/server.cc:833 Usage of the deprecated runtime key overload.global_downstream_max_connections, consider switching to `envoy.resource_monitors.downstream_connections` instead.This runtime key will be removed in future. thread=20
Previously attempted in https://github.com/istio/istio/pull/47474, but it was alpha at the time.
Now its stable though. Time to move?
One question I have -- we are actually setting this to set the limit to ~max_int. Do we really need it at all?
cc @briansonnenberg
You're right that from an overload protection point of view it's quite useless. Unless there's some other reason I'm unaware of regarding users configuring their own value and we just needed a safe default?
IIRC when the feature was added originally it would give a bunch of spam if you did not set it. Like not just a log, but 100s of logs or something. We couldn't set it to anything low because its dangerous for us to arbitrarily deny connections when we are dealing with arbitrary workloads, so we set it to the max to silence the logs really
My vote would be to remove this and see what happens now instead of moving those to resource monitors OOB.
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2024-02-27. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.
I am seeing this error since upgrading to istio v1.22.2, is there a config fix/workaround or will it be addressed in a new version of istio?
