istio icon indicating copy to clipboard operation
istio copied to clipboard

istioctl experimental metrics: add service metrics support

Open nicole-lihui opened this issue 3 years ago • 3 comments

Please provide a description of this PR: user-facing:

# istioctl experimental metrics support format:  [<resource type>/]<name>[.<namespace>]


# Retrieve workload metrics for productpage-v1 workload with resource type [workload] 
istioctl experimental metrics workload/productpage-v1

# Retrieve service metrics for productpage with resource type [service] 
istioctl experimental metrics service/productpage

# Retrieve service metrics for various services in the different namespaces
istioctl experimental metrics service/productpage.foo

# Retrieve workload metrics for various services with resource type [service] in the different namespaces
istioctl experimental metrics service/productpage.foo service/reviews.bar

more info: issue: https://github.com/istio/istio/issues/36428 doc: https://docs.google.com/document/d/1ATp4qCHktncfAFjH_S9yWm9dGxI_aXHN2cw1AD4kveQ/edit?usp=sharing

nicole-lihui avatar Jul 06 '22 02:07 nicole-lihui

@zirain PR https://github.com/istio/istio/pull/37822 not stale Before the PR has a problem, submit a new PR, If you have interest can follow up this PR, Thank you 😄 。

nicole-lihui avatar Jul 06 '22 02:07 nicole-lihui

@douglas-reid Does this PR meet the expectation? This PR is the first step of the improvement, and some of the designs are for extensibilities of future designs like --from, --to and --namespace

nicole-lihui avatar Jul 08 '22 05:07 nicole-lihui

Sorry, I missed this activity. Still interested in merging?

douglas-reid avatar Aug 29 '22 22:08 douglas-reid

Sorry, I missed this activity. Still interested in merging?

@douglas-reid it doesn't matter ~

I am very interested in it

nicole-lihui avatar Aug 30 '22 08:08 nicole-lihui

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-08-30. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar Oct 15 '22 05:10 istio-policy-bot

@nicole-lihui, @douglas-reid, @zirain Hello! What happened to this PR and why it was not merged?

oxxenix avatar Oct 25 '22 09:10 oxxenix