istio icon indicating copy to clipboard operation
istio copied to clipboard

Renaming base chart as istio base

Open anastasiagrinman opened this issue 3 years ago • 6 comments

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)

Describe the feature request Rename Istio base chart name to istio-base

Describe alternatives you've considered The chart name cannot have "base" name, since there a lot of base projects and the chart needs to be defined as an base with istio context. ref: https://artifacthub.io/packages/helm/istio-official/base

Affected product area (please put an X in all that apply)

[ ] Docs [X] Installation [ ] Networking [ ] Performance and Scalability [ ] Extensions and Telemetry [ ] Security [ ] Test and Release [X] User Experience [X] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster [ ] Virtual Machine [ ] Multi Control Plane

Additional context

anastasiagrinman avatar Feb 08 '22 10:02 anastasiagrinman

Why not? When you install you use helm install istio/base. It seems redundant to put Istio twice. Everything is namespaced so I don't see any reason to prefix things with Istio?

howardjohn avatar Feb 08 '22 14:02 howardjohn

I think it makes sense to rename it to istio-base as usually all of us have many helm repos for our use, so the helm chart should be named properly as well, we cannot only really on helm repo local name, which can be anything. The good example is https://artifacthub.io/packages/helm/istio-official/base :-)

rimusz avatar Feb 09 '22 08:02 rimusz

I am still not seeing the issue. When you install it you can name it whatever you want including istio-base

howardjohn avatar Feb 09 '22 14:02 howardjohn

The issue is not with the release name as we call it during the installation. If you set an istio repo as a remote for pulling the images from the private registry, the problem may occur with another chart names that already have the same name. Does it make sense?

anastasiagrinman avatar Feb 09 '22 15:02 anastasiagrinman

I don't know what you mean about private registry. This is a helm chart, not a docker image...?

There are namespaces for a reason - I wouldn't expect every chart name to be unique because we have a namespace (istio) for it. Seems very redundant to call this istio/istio-base - we are just repeating ourselves.

howardjohn avatar Feb 09 '22 16:02 howardjohn

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-02-09. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar Aug 24 '22 05:08 istio-policy-bot