istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

Adds cert-management/istio-csr task documentation for cert-manager integration

Open JoshVanL opened this issue 4 years ago • 10 comments

This PR adds a task for using istio-csr which enables integration with cert-manager. cert-manager has support for many external CA issuers, which can be used to setup and sign all certificates in Istio.

Let me know if this is appropriate to add in! Happy to have a go at setting up some tests for this.

[ ] Configuration Infrastructure [ ] Docs [ ] Installation [ ] Networking [ ] Performance and Scalability [ ] Policies and Telemetry [ x ] Security [ ] Test and Release [ ] User Experience [ ] Developer Infrastructure

JoshVanL avatar Feb 04 '21 18:02 JoshVanL

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines, and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built as a full copy of the istio.io website. You can find this preview by clicking on the Details link next to the deploy/netlify entry in the Status section of this page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the status section of the page. Click on the Details link to get a list of the problems with your PR. Fix those problems and push an update to your PR. This will automatically rerun the tests and hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up on https://preliminary.istio.io. The changes will be published to https://istio.io the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Feb 04 '21 18:02 istio-policy-bot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Feb 04 '21 18:02 google-cla[bot]

Hi @JoshVanL. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 04 '21 18:02 istio-testing

/ok-to-test

Waiting on suggested fix from Eric and CLA

craigbox avatar Mar 23 '21 11:03 craigbox

@googlebot I signed it!

JoshVanL avatar Mar 25 '21 11:03 JoshVanL

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 25 '21 11:03 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 25 '21 16:03 googlebot

@googlebot I signed it!

JoshVanL avatar Apr 09 '21 16:04 JoshVanL

@JoshVanL: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lint_istio.io d0f9051ad2948bbd60a4cccb349b00755f5f71c3 link /test lint_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Apr 28 '21 13:04 istio-testing

/retest

craigbox avatar Nov 09 '23 04:11 craigbox

@JoshVanL: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile_default_istio.io d0f9051ad2948bbd60a4cccb349b00755f5f71c3 link true /test doc.test.profile_default
gencheck_istio.io d0f9051ad2948bbd60a4cccb349b00755f5f71c3 link true /test gencheck
lint_istio.io d0f9051ad2948bbd60a4cccb349b00755f5f71c3 link true /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Nov 09 '23 04:11 istio-testing