istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

Run subset of doc tests in presubmit

Open frankbu opened this issue 4 years ago • 4 comments

Running the full suite of doc tests in presubmit is a waste of time because most PRs are only changing a small number (often just one) doc. In fact, sometimes the changed doc in the PR doesn't even have any associated test (e.g., a concepts doc).

Since we now have the ability to test subsets of the docs, it would be great if during presubmit we only run the tests associated with changed files in the PR. For example:

  1. PR with changed file: content/en/docs/tasks/traffic-management/request-routing/index.md
  2. Run test command make doc.test TEST=tasks/traffic-management/request-routing

If more than one test needs to run, they can be passed to the TEST= variable as a comma-separated list.

frankbu avatar Jul 21 '20 21:07 frankbu

One special case: A PR that updates the istio/istio SHA, used for testing, should run the full suite.

frankbu avatar Jul 21 '20 21:07 frankbu

@ericvn or @sdake does one of you have any bandwidth to help with this?

linsun avatar Jul 22 '20 14:07 linsun

I should have some time to help with this.

ericvn avatar Jul 22 '20 15:07 ericvn

Thank you @ericvn !

linsun avatar Jul 22 '20 15:07 linsun

Fixed by #12564

frankbu avatar Feb 14 '23 15:02 frankbu