istio.io
istio.io copied to clipboard
Document use of ambient wrapper chart in 1.23 install/upgrade guides
Description
Fixes https://github.com/istio/istio.io/issues/15167
Note that until at least a 1.23 prerelease build is published, the ambient chart will not show up in the documented repo, see https://github.com/istio/release-builder/pull/1849
To test locally in the meantime, you can use the local copies of the chart, so instead of doing:
helm install istio-ambient istio/ambient -n istio-system --create-namespace --wait
like the doc says, do
helm install ambient ./manifests/charts/ambient -n istio-system --create-namespace --wait
(you may need to run helm dep update ./manifests/charts/ambient first to populate the depcache)
I left both the individual and wrapper modes in both docs.
Reviewers
- [x] Ambient
- [x] Docs
- [x] Installation
- [ ] Networking
- [ ] Performance and Scalability
- [ ] Extensions and Telemetry
- [ ] Security
- [ ] Test and Release
- [ ] User Experience
- [ ] Developer Infrastructure
- [ ] Localization/Translation
/test gencheck
/test doc.test.profile-default
/cc @costinm for opinions per comment
/retest-required
Do we want to have this in get started guide as the wrapper chart is mainly to show how simple it is to install Istio for demo purpose?
Just to recap some discussion from Monday's TOC, unfortunately the attendance is relative low, but folks on the call @therealmitchconnors @keithmattix @howardjohn and myself prefer to have the simple 1 helm install for demo purpose (or consider using helmfile as an alternative if we choose not to publish the wrapper chart). One primary concern is not to show people multiple ways to do Install within 1 install method (which is helm here) and the existing helm install instructions offer more flexibility than the wrapper chart. Please correct me if I am wrong here in capturing the discussion.
Do we want to have this in get started guide as the wrapper chart is mainly to show how simple it is to install Istio for demo purpose?
:+1: I'll make that change, it makes sense.
The other key part of the TOC discussion was to move this chart wrapper under samples/. We can still publish to OCI (and probably should!), but under "samples" in some way (could be gcr.io/istio-release/samples/...)
The other key part of the TOC discussion was to move this chart wrapper under
samples/. We can still publish to OCI (and probably should!), but under "samples" in some way (could be gcr.io/istio-release/samples/...)
:+1: I assume that's release-builder changes, will do.
@linsun @craigbox et al - PTAL:
- Moved the
simple Helminstructions togettting started - Left the
full Helminstructions inhelm install
tweaked wording and such.
Chart move PR: https://github.com/istio/istio/pull/52013
Chart publish under "samples" PR: https://github.com/istio/release-builder/pull/1901
@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| doc.test.profile-ambient_istio.io | 8f6c1a62faccf56e58ff0deff63708e09d612fd0 | link | true | /test doc.test.profile-ambient |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Test failure is because the extend-wasm guide uses the Gateway API install docs from the getting started page, which were removed when we went to Helm.
Test failure is because the extend-wasm guide uses the Gateway API install docs from the getting started page, which were removed when we went to Helm.
Yeah I fixed some of this in https://github.com/istio/istio.io/pull/15474 - that one should probably go in before this one, and I'll resync this one pending the outcome of https://github.com/istio/istio.io/pull/15279#discussion_r1695641694
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
FYI, I added this PR to ambient meeting agenda for tmr.
Aight so current consensus: https://docs.google.com/document/d/1SMlwliEnthgq7r2PjpLl1kCq3t8rAMbgu6r_lDAXJ0w/edit#heading=h.ttmnrtyxr98j
- we aren't going to document the wrapper chart (gonna close this PR)
- The wrapper chart is published under
samples: https://github.com/istio/release-builder/pull/1901 but I am not comfortable publishing an artifact we do not document or doctest (which is why this PR was opened) - for now there seems to be a desire to leave it published but not document or doctest it, so I will leave it.