istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

Egress Gateway, istioctl command wrap with dquotes

Open Seokyun-Ha opened this issue 1 year ago • 4 comments

Description

Reviewers

  • [ ] Ambient
  • [ ] Docs
  • [ ] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Extensions and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [ ] User Experience
  • [ ] Developer Infrastructure
  • [ ] Localization/Translation

Seokyun-Ha avatar Feb 20 '24 03:02 Seokyun-Ha

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines, and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with a full copy of the istio.io website. You can find this preview by clicking on the Details link next to the deploy/netlify entry in the status section of this page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the lint_istio.io entry in the status section. Click on the Details link to get a list of the problems with your PR. Fix those problems and push an update; this will automatically re-run the tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up on https://preliminary.istio.io. The changes will be published to https://istio.io the next time we do a major release (which typically happens every 3 months or so). To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Feb 20 '24 03:02 istio-policy-bot

Hi @Seokyun-Ha. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 20 '24 03:02 istio-testing

Please sign the CLA

windsonsea avatar Feb 20 '24 06:02 windsonsea

When I use previous command, I got parsing error because of square brackets [0].

On other pages in istio.io, the command parameters are wrapped with quotes/dquotes when useing sqaure brackets.

Examples:

image https://istio.io/latest/docs/ops/ambient/getting-started/

image https://istio.io/latest/docs/tasks/traffic-management/circuit-breaking/

I think it's more safe to wrap with quotes/dquote.

Seokyun-Ha avatar Feb 21 '24 10:02 Seokyun-Ha

Also, I've signed EasyCLA. Thanks for letting me know 👍 (BlueHorn07 is also my Github account, sorry for confusing)

Seokyun-Ha avatar Feb 21 '24 10:02 Seokyun-Ha