istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

Correct Istio Upgrade version step message

Open cathal-c opened this issue 11 months ago • 4 comments

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • [ ] Ambient
  • [X] Docs
  • [X] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Extensions and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [X] User Experience
  • [ ] Developer Infrastructure

The existing message implies that upgrading two minor versions is supported, and indeed this has historically been the case, at least anecdotally.

The Istio 1.17 control plane however, is not compatible with Istio 1.15 proxies, breaking that soft rule. That should be reflected here, to prevent users from incorrectly jumping multiple minor versions.

cathal-c avatar Aug 18 '23 06:08 cathal-c

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: CathalC2011 / name: Cathal (42ba7f1fa75df087f8313fdf0838797e56259c43)

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines, and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built as a full copy of the istio.io website. You can find this preview by clicking on the Details link next to the deploy/netlify entry in the Status section of this page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the status section of the page. Click on the Details link to get a list of the problems with your PR. Fix those problems and push an update to your PR. This will automatically rerun the tests and hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up on https://preliminary.istio.io. The changes will be published to https://istio.io the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Aug 18 '23 06:08 istio-policy-bot

Hi @CathalC2011. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Aug 18 '23 06:08 istio-testing

Would you point to where this is discussed. Is this maybe related to this https://github.com/istio/istio/issues/43785? I believe there was an issue upgrading to 1.17.0 and 1.17.1 but it was fixed in 1.17.2.

ericvn avatar Aug 18 '23 14:08 ericvn