istio.io
istio.io copied to clipboard
istio
Test moving up Hugo versions and replace BlackFriday with GoldMark.
Please provide a description for what this PR is for.
In the past there were issues with URLs in GoldMark and we kept reverting back to BlackFriday. BlackFriday has finally been removed from the latest Hugo versions, so let's see what's broken.
https://deploy-preview-11534--preliminary-istio.netlify.app/latest/about/ecosystem is one back with issues.
Quick investigation: it's https://github.com/gohugoio/hugo/issues/6553.
The parser seems to want to take four-space indents in source files and turn them into code blocks. We may have to fix some templates, possibly by removing | markdownify from shortcode blocks, or possibly by removing the indents from whatever they're trying to render.
(There's a strip_indent partial called from the tabset shortcode; it could be that, not be doing it's job properly.)
@craigbox I removed all markdownify stanzas and noted the about/ecosystem seemed to be good. However about/deployment had issues with links. I did note that the links had ../../*docs in them (which we don't have anywhere else (we say to use .docs) so I tried that change. That didn't help. I did add back the markdownify for centered blocks (only used in the /about tree) and it seemed to fix it.
Let's see how this looks..
https://deploy-preview-11534--preliminary-istio.netlify.app/latest/docs/ops/diagnostic-tools/istioctl/ has an issue the tab section...
At this point, I don't see the remaining changed layouts being used in the repo (at least in the non-archive directories. I haven't looked at archived directories to see if they have issues.
So adding it back to tab-system fixes the https://deploy-preview-11534--preliminary-istio.netlify.app/latest/docs/ops/diagnostic-tools/istioctl/ and breaks the eco-system again. Argh..
@craigbox Thoughts on these changes. Right now the output seems good for the few areas I had looked at it the past and seen issues.
I might just put the markdownify back in the places it was removed) or can likely remove those layouts entirely since I don't think they are used (haven't actually tried removing them).
Tried removing them and only layouts/partials/section_description.html was able to be removed.
Removing the DNM. I've done some more looking and haven't found anymore issues.