istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

fix table width error

Open Arhell opened this issue 2 years ago • 8 comments

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • [ ] Configuration Infrastructure
  • [ ] Docs
  • [ ] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Policies and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [x] User Experience
  • [ ] Developer Infrastructure

resove https://github.com/istio/istio.io/issues/11516

Arhell avatar Jun 29 '22 21:06 Arhell

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

istio-testing avatar Jun 29 '22 21:06 istio-testing

✅ https://deploy-preview-11522--preliminary-istio.netlify.app/latest/docs/releases/feature-stages/#feature-phase-definitions ❌ https://deploy-preview-11522--preliminary-istio.netlify.app/latest/docs/reference/commands/pilot-agent/#envvars

craigbox avatar Jul 01 '22 12:07 craigbox

@craigbox can make minimum width for pc?

Arhell avatar Jul 01 '22 12:07 Arhell

I've had a quick play around with various options for table-layout: fixed and word-break: break-word, none of them seem to fix this.

We could change Hugo to add tags to code blocks where underscores are? Thoughts, @ericvn ?

craigbox avatar Jul 01 '22 12:07 craigbox

I've had a quick play around with various options for table-layout: fixed and word-break: break-word, none of them seem to fix this.

We could change Hugo to add tags to code blocks where underscores are? Thoughts, @ericvn ?

the problem is that there are just long words, not just blocks of code

Arhell avatar Jul 01 '22 12:07 Arhell

we could make you scroll inside the table?

It looks like the layout engine seems to prefer using the first row as a guideline on how wide the columns should be, which doesn't make any sense.

I don't think we want to make users hint at which columns should be what width when they create tables either.

craigbox avatar Jul 01 '22 12:07 craigbox

here is an example with scrolling Screenshot_1 the same but without scrolling but there is a strip that scroll can be Screenshot_2

Arhell avatar Jul 01 '22 13:07 Arhell

@craigbox Please take a look, it's not bad. But some tables are not full width, I think this is not critical

Arhell avatar Jul 02 '22 13:07 Arhell

Hey Ihor, I wasn't sure quite what to do with this one (I've had it open for a long time!) I am not sure it was better to merge or not, but happy to take your feedback if you have any more.

craigbox avatar Sep 27 '22 23:09 craigbox

Hey Ihor, I wasn't sure quite what to do with this one (I've had it open for a long time!) I am not sure it was better to merge or not, but happy to take your feedback if you have any more.

Hello, so-so solution, when I made edits so that the content would not get out, I wrote like there might be small problems because there is no way to take into account everything. But in any case, what is done is better than it was when the content climbed off the screen

Unfortunately there is no perfect solution it all depends on the content

Arhell avatar Sep 27 '22 23:09 Arhell