istio.io
istio.io copied to clipboard
istio
Fix subzone link not found
In link https://istio.io/latest/docs/tasks/traffic-management/locality-load-balancing/, the topology.istio.io/subzone link does not exist.
And to help us figure out who should review this PR, please put an X in all the areas that this PR affects.
- [ ] Configuration Infrastructure
- [x] Docs
- [ ] Installation
- [ ] Networking
- [ ] Performance and Scalability
- [ ] Policies and Telemetry
- [ ] Security
- [ ] Test and Release
- [ ] User Experience
- [ ] Developer Infrastructure
@craigbox I had the same doubt at the beginning. Before using the master version, I was tried to use the permalink. I agree that both of the implementations have their own flaws, and we may discuss which one is more preferred.
Can we just use something like github_blob which takes into account the currently built branch? Since this is in api, we could create another shortcode that use the api repo. It doesn't help if the line number changes in the file across releases.
@hanxiaop would love to see this moved forward, so have marked it to be open.
@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| lint_istio.io | d360ec3e64d226cfa56b51eb42a5009c846cf57f | link | true | /test lint_istio.io |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@ericvn How about other links using https://github.com/istio/api/blob? After I added the lint check for github_api_blob, I realized there are lots of places using the api link right now, and some of the links will be invalid as well if I replace them with the github_api_blob form. Should they keep the original permalink form or should we do something?
@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| lint_istio.io | d360ec3e64d226cfa56b51eb42a5009c846cf57f | link | true | /test lint_istio.io |
| doc.test.profile_default_istio.io | d360ec3e64d226cfa56b51eb42a5009c846cf57f | link | true | /test doc.test.profile_default |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.