istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

Adding Bitvavo Company

Open guyromb opened this issue 2 years ago • 11 comments

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • [ ] Configuration Infrastructure
  • [ X ] Docs
  • [ ] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Policies and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [ ] User Experience
  • [ ] Developer Infrastructure

guyromb avatar Sep 23 '21 12:09 guyromb

😊 Welcome! This is either your first contribution to the Istio documentation repo, or it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines, and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built as a full copy of the istio.io website. You can find this preview by clicking on the Details link next to the deploy/netlify entry in the Status section of this page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the status section of the page. Click on the Details link to get a list of the problems with your PR. Fix those problems and push an update to your PR. This will automatically rerun the tests and hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up on https://preliminary.istio.io. The changes will be published to https://istio.io the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Sep 23 '21 12:09 istio-policy-bot

Hi @guyromb. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Sep 23 '21 12:09 istio-testing

/ok-to-test

rvennam avatar Sep 23 '21 12:09 rvennam

Thanks for adding yourself to the company list!

rvennam avatar Sep 23 '21 12:09 rvennam

@Arhell please see our review comments. Eric's comment should fix the lint test

rvennam avatar Sep 29 '21 02:09 rvennam

@Arhell please see our review comments. Eric's comment should fix the lint test

I understand, I will keep in mind, thanks

Arhell avatar Sep 29 '21 03:09 Arhell

@rvennam is it possible different directory for the logo?

guyromb avatar Oct 01 '21 09:10 guyromb

You have to commit a copy to our /logos directory, it's not served from your site.

craigbox avatar Oct 01 '21 09:10 craigbox

@guyromb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 4d9ebbe09c540b90f35f700184a913bfb838d648 link true /test lint_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Oct 01 '21 09:10 istio-testing

@guyromb please update so we can merge this!

craigbox avatar Nov 02 '21 12:11 craigbox

bump, @guyromb !

craigbox avatar Jan 10 '22 01:01 craigbox

@guyromb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 4d9ebbe09c540b90f35f700184a913bfb838d648 link true /test lint_istio.io
doc.test.profile_default_istio.io 4d9ebbe09c540b90f35f700184a913bfb838d648 link true /test doc.test.profile_default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Feb 01 '23 19:02 istio-testing

Closing this for now since it seems abandoned. Please reopen adding the svg if you would like this merged.

ericvn avatar Mar 03 '23 19:03 ericvn