installer icon indicating copy to clipboard operation
installer copied to clipboard

Published 20 hours ago • verified publisher icon istio

add tolerations

Open richardwxn opened this issue 5 years ago • 8 comments

To resolve https://github.com/istio/istio/issues/19480

richardwxn avatar Dec 10 '19 19:12 richardwxn

@howardjohn yep we should actually use the k8s specs under IstioControlPlane, but there are users complain that we claim to still support helm api at this stage so they tend to believe that overlaying k8s settings under values passthrough part would work as the same as in IstioControlPlane spec.

As an alternative, I have a change locally to improve the validation function, for example it should give a warning and suggests the correct path when user try to set in values pass through

richardwxn avatar Dec 11 '19 00:12 richardwxn

@howardjohn

Why not just use the k8s spec?

Because there is no way to specify it through k8s spec. I am using k8s spec as much as possible, but several components are not part of the ControlPlaneSpec

nick4fake avatar Dec 12 '19 13:12 nick4fake

@nick4fake seems like its in the proto: https://github.com/istio/operator/blob/8569a17c89f10190d5e799c3e10b9426c18883b3/pkg/apis/istio/v1alpha2/istiocontrolplane_types.proto#L512 does it not work?

howardjohn avatar Dec 12 '19 16:12 howardjohn

@howardjohn I think the problem is that it is not defined in the templates of kiali and tracing, unless they do a k8soverlay

richardwxn avatar Dec 13 '19 01:12 richardwxn

I think the problem is that it is not defined in the templates of kiali

The Kiali integration will support these toleration settings once these two installer/operator PRs are able to get merged ;-)

  • istio/installer PR 556: https://github.com/istio/installer/pull/556/files#diff-44b3244d775b916bfc710c4dd80b433bR34 https://github.com/istio/installer/pull/556/files#diff-4fc69d9eb27e507429323cb933f7ad3bR16 https://github.com/istio/installer/pull/556/files#diff-d2ae3febaa0204735dffb73c835471ddR62

  • istio/operator PR 662: https://github.com/istio/operator/pull/622/files#diff-833bbe66939c20c7f9ce787aafc95e06R708

jmazzitelli avatar Dec 13 '19 01:12 jmazzitelli

we can unblock it for tracing and kiali toleration first

richardwxn avatar Dec 16 '19 18:12 richardwxn

PTAL @howardjohn

richardwxn avatar Dec 17 '19 19:12 richardwxn

@richardwxn: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 12 '20 17:02 istio-testing