installer icon indicating copy to clipboard operation
installer copied to clipboard

add workloads config to kiali

Open yacut opened this issue 6 years ago • 5 comments

related to https://github.com/istio/istio/pull/18819

yacut avatar Nov 12 '19 09:11 yacut

Hi @yacut. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Nov 12 '19 09:11 istio-testing

@yacut: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_installer 1e4790b68cddb9645da88369156741168476520d link /test lint_installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Nov 19 '19 10:11 istio-testing

same change has been made in the PR https://github.com/istio/installer/pull/556 that moves to the Kiali operator.

jmazzitelli avatar Nov 19 '19 16:11 jmazzitelli

@yacut I am not really sure what this does. Similar in vein to the comments here https://github.com/istio/installer/pull/546#issuecomment-558066361 I think we should get out of the third party install business and into the third party integration business (via their operators).

Cheers -steve

sdake avatar Nov 25 '19 09:11 sdake

FWIW: I have included this in the kiali operator integration PR: https://github.com/istio/installer/pull/556/files#diff-d2ae3febaa0204735dffb73c835471ddR88-R91

So the kiali operator integration will have the ability for the user to tell kiali which types of workloads to ignore.

We can close this PR once those kiali operator PRs are merged since this PR will not be relevant anymore.

jmazzitelli avatar Nov 25 '19 10:11 jmazzitelli