cni icon indicating copy to clipboard operation
cni copied to clipboard

Perform preemption check only when used as a chained plugin

Open luksa opened this issue 4 years ago • 2 comments

When Istio CNI is not used as a chained plugin, throwing an error or logging the preemption warning doesn't make sense. For example, when using Multus CNI, multiple CNI config files are in the same dir, but none of them has precedence over the others, as they are loaded by name. In that case, logging the warning isn't appropriate.

luksa avatar Feb 26 '20 14:02 luksa

😊 Welcome @luksa! This is either your first contribution to the Istio cni repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Feb 26 '20 14:02 istio-policy-bot

Hi @luksa. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 26 '20 14:02 istio-testing