istio
Expose retry_budget within API DestinationRule ConnectionPoolSettings
Expose the Envoy CircuitBreaker retry_budget ConnectionPoolSettings within DestinationRule ConnectionPoolSettings HTTP configuration.
Credit to @quraynai as I used https://github.com/istio/api/pull/2734 as a reference.
Issue: https://github.com/istio/istio/issues/27419
😊 Welcome @ericdbishop! This is either your first contribution to the Istio api repo, or it's been a while since you've been here.
You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines by referring to Contributing to Istio.
Thanks for contributing!
Courtesy of your friendly welcome wagon.
Hi @ericdbishop. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I provided more context in my PR in the main repo https://github.com/istio/istio/pull/51823
This was raised up again and again in the past, it's really meaningful.
Even knowing that this conflicts with an long timeexisting feature, I do think DestiontaionRule is the most appropriate place.
@zirain we are discussing in https://github.com/istio/istio/pull/51823 if you'd like to join in the conversation.
@mikemorris will sync with @ericdbishop offline - we want to have this in gateway API first then implement in Istio.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.