api icon indicating copy to clipboard operation
api copied to clipboard

feat(DestinationRules): Adding aggression and min_weight_percent to DestinationRules API

Open frgaudet opened this issue 1 month ago • 11 comments

Adding envoy slowStartMode aggression and min_weight_percent parameters to DestinationRules API

Fixes https://github.com/istio/api/issues/3215

Next PR to come on the cluster_traffic_policy side

First time I contribute here, hope this is good :)

frgaudet avatar May 23 '24 15:05 frgaudet

😊 Welcome @frgaudet! This is either your first contribution to the Istio api repo, or it's been a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar May 23 '24 15:05 istio-policy-bot

Hi @frgaudet. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

istio-testing avatar May 23 '24 15:05 istio-testing

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

istio-policy-bot avatar May 23 '24 15:05 istio-policy-bot