api icon indicating copy to clipboard operation
api copied to clipboard

Run `make gen` with the new build-tools to generate new html

Open ericvn opened this issue 1 year ago • 5 comments

The new build-tools has a new markdown generator for the html files (same as the one used by istio.io. The PR is simply make gen with the new build-image to update the html files.

This PR is needed to prevent other PRs from having to check these changes in.

ericvn avatar Oct 14 '22 20:10 ericvn

The gen-check test will pass when the pipeline moves to the same image as the istio/api repos is using.

ericvn avatar Oct 14 '22 20:10 ericvn

/test release-notes

ericvn avatar Oct 14 '22 20:10 ericvn

/test gencheck

zirain avatar Oct 15 '22 00:10 zirain

@ericvn this should merge first?

zirain avatar Oct 15 '22 07:10 zirain

@zirain I was waiting for the 2 needed approvals for this PR. Once the approvals are in place, I will merge https://github.com/istio/test-infra/pull/4331 which will update the pipeline to use the new image. At that point, the gencheck for this PR will pass and then merge.

If I simply merge the test-infra PR, then the gencheck will fail in other PRs unless they also include these changes for all files, not just what they are changing.

If a user tries to run make gen on the current commit and submit the PR, they will have the same gencheck failure this PR does as the repo and tooling are out of sync.

Hopefully, we can get the two PRs merged soon.

ericvn avatar Oct 16 '22 16:10 ericvn

/test gencheck

ericvn avatar Oct 17 '22 13:10 ericvn