api
api copied to clipboard
istio
add injectionSelectors
InjectionSelectors is a list of Kubernetes selectors that specify the set of namespaces, Istio will create istio-ca-root-cert configmap in selected namespaces.If omitted, Istio will create istio-ca-root-cert configmap in all namespaces except kubernetes system namespaces.
Fix https://github.com/istio/istio/issues/31115
Hi @liuxu623. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.
@liuxu623 you need a rebase on this PR as well?
@kfaseela Please help me review code, thank you.
@liuxu623 you need a rebase on this PR as well?
@kfaseela Please help me review code, thank you.
sure..will do.. but considering this is an API change, I assume you would have already discussed this in one of the working group meetings, and got a consensus for this enhancement?
@liuxu623 you need a rebase on this PR as well?
@kfaseela Please help me review code, thank you.
sure..will do.. but considering this is an API change, I assume you would have already discussed this in one of the working group meetings, and got a consensus for this enhancement?
No, I didn't discuss this with working group yet...
Do you have a high-level design? There are too many factors to consider for multi-tenants, we need a design.
@liuxu623: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Do you have a high-level design? There are too many factors to consider for multi-tenants, we need a design.
https://docs.google.com/document/d/1y4liRJbQW0NCMeQtqMma46flVqs-izV1/
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-09-14. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.
Created by the issue and PR lifecycle manager.