istio
Authorization policy: allow specifying string match for path and conditions
Add StringMatcher options to Path and Condition in AuthorizationPolicy. We use the same StringMatcher as used in VirtualHosts to provide consistent matching in both. If both String and StringMatcher are present, they should be appended.
Fixes https://github.com/istio/istio/issues/16585 Related: https://github.com/istio/istio/pull/35641
@howardjohn wdyt? this way we can prevent introducing breaking changes in the exiting APIs but still support matching by regex as needed.
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.
😊 Welcome @sschepens! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.
You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.
Thanks for contributing!
Courtesy of your friendly welcome wagon.
Hi @sschepens. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@howardjohn what is your opinion on this? I would like to make progress on this feature, it is something that many people need.
@sschepens: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Yes please someone validate the PR, a lot of people are waiting this feature for so long
Closing due to implementation in https://github.com/istio/istio/pull/50365
