api icon indicating copy to clipboard operation
api copied to clipboard

Published 20 hours ago • verified publisher icon istio

Add verbose flag for envoy tracing

Open commixon opened this issue 3 years ago • 5 comments

Here we add the verbose flag for envoy tracing.

As it is right now, istio annotates spans with additional data by default, which will produce sometimes a lot more "span events" than intended. This is an easy way to control span "verbosity" which is already supported in envoy.

Reference: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto.html?highlight=verbose

commixon avatar Oct 20 '21 11:10 commixon

😊 Welcome @commixon! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Oct 20 '21 11:10 istio-policy-bot

Hi @commixon. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Oct 20 '21 11:10 istio-testing

Ping comment to maybe get some traction? :)

commixon avatar Nov 03 '21 11:11 commixon

I am interested in this feature as well 👍

vlinevych avatar Dec 13 '21 16:12 vlinevych

@commixon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Mar 16 '22 22:03 istio-testing

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-10-20. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar May 15 '24 23:05 istio-policy-bot