api icon indicating copy to clipboard operation
api copied to clipboard

Istio API Feature Status using proto annotations

Open zhlsunshine opened this issue 3 years ago • 45 comments

According to proposal design doc, FieldOptions of proto3 can be used to implement this feature label, and I just change the code for Export To feature as PoC work.

Thank you for your time for reviewing this PR! ^_^

zhlsunshine avatar Jun 01 '21 07:06 zhlsunshine

😊 Welcome @zhlsunshine! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Jun 01 '21 07:06 istio-policy-bot

/test release-notes_api

zhlsunshine avatar Jun 01 '21 07:06 zhlsunshine

Adding @jasonwzm who authored this design.

therealmitchconnors avatar Jun 02 '21 01:06 therealmitchconnors

@zhlsunshine Thanks for working on this! The feature name should be from the features defined in Istio repos. Do you plan to help implement the proto feature status? If so, we should definitely sync before more work is done this. :) Your contribution is much appreciated!

jasonwzm avatar Jun 02 '21 23:06 jasonwzm

@jasonwzm yes, it will be great if I can help on the proto feature status. And I also hope to sync with u @jasonwzm @therealmitchconnors for the next step. ^_^

zhlsunshine avatar Jun 03 '21 02:06 zhlsunshine

/test build_api

zhlsunshine avatar Jul 02 '21 06:07 zhlsunshine

/test build_api

zhlsunshine avatar Jul 02 '21 06:07 zhlsunshine

Hi @jasonwzm & @therealmitchconnors, as discussed earlier, I have added field ID to template proto and option ID to all export_to fields in networking API. Could you please help to review and approve this PR when you are available? Thanks! ^_^

zhlsunshine avatar Jul 02 '21 06:07 zhlsunshine

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 08 '21 02:07 google-cla[bot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 08 '21 02:07 google-cla[bot]

:frowning_face: Sorry, but only Googlers may change the label cla: yes.

google-cla[bot] avatar Jul 08 '21 02:07 google-cla[bot]

:frowning_face: Sorry, but only Googlers may change the label cla: yes.

google-cla[bot] avatar Jul 08 '21 02:07 google-cla[bot]

@googlebot I consent

zhlsunshine avatar Jul 08 '21 03:07 zhlsunshine

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 08 '21 03:07 google-cla[bot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 08 '21 07:07 google-cla[bot]

@googlebot I consent

zhlsunshine avatar Jul 08 '21 07:07 zhlsunshine

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 08 '21 07:07 google-cla[bot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 12 '21 15:07 google-cla[bot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 12 '21 15:07 google-cla[bot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 12 '21 15:07 google-cla[bot]

Hi @justinpettit , I posted a new submit, could you please help to review when u r available? Thanks! ^_^

zhlsunshine avatar Jul 13 '21 08:07 zhlsunshine

Hi @howardjohn & @brian-avery could you please help to approve this PR when you are available? Thanks!

zhlsunshine avatar Jul 16 '21 07:07 zhlsunshine

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 22 '21 03:07 google-cla[bot]

:frowning_face: Sorry, but only Googlers may change the label cla: yes.

google-cla[bot] avatar Jul 22 '21 07:07 google-cla[bot]

Hi @louiscryan any update?

zhlsunshine avatar Jul 23 '21 01:07 zhlsunshine

Hi @howardjohn, could you please help me to add the cla/google label? Thanks!

zhlsunshine avatar Jul 27 '21 07:07 zhlsunshine

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot avatar Jul 27 '21 15:07 googlebot

@googlebot I consent

zhlsunshine avatar Jul 28 '21 01:07 zhlsunshine

:frowning_face: Sorry, but only Googlers may change the label cla: yes.

google-cla[bot] avatar Jul 29 '21 04:07 google-cla[bot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 29 '21 20:07 google-cla[bot]