api icon indicating copy to clipboard operation
api copied to clipboard

Issue with docs/reference/config/istio.operator.v1alpha1/index.html

Open dsbos opened this issue 4 years ago • 3 comments

The section at https://istio.io/latest/docs/reference/config/istio.operator.v1alpha1/#K8sObjectOverlay-PathValue says:

All values are strings but are converted into appropriate type based on schema.

That would probably be clearer (and be consistent with the style of the preceding text) if it said:

All values are strings but are converted into the appropriate type based on the schema.

(Or maybe "... based on schemas" (well, formally, "schemata"), if that reflects the author's intended meaning better.)

dsbos avatar Dec 31 '20 14:12 dsbos

Note that this is auto-generated. It comes from https://github.com/istio/api/blob/master/operator/v1alpha1/operator.proto#L318 and will need to be changed there.

esnible avatar Mar 04 '21 20:03 esnible

@ostromart Tentatively assigning to you. Feel free to reassign, unassign, or close.

esnible avatar Mar 08 '21 20:03 esnible

Thanks for reviewing and bringing this up @dsbos. Would you be interested in contributing some PR's to improve the docs, for this any any other issues you find?

ostromart avatar Mar 08 '21 22:03 ostromart

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-03-08. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar May 14 '24 22:05 istio-policy-bot