api icon indicating copy to clipboard operation
api copied to clipboard

add support for zone/subzone level failover settings

Open masquee opened this issue 3 years ago • 4 comments

Current failover settings only support failover from one region to another region, but sometimes we prefer to failover from one zone to another zone, even from one subzone to another subzone.

This pull request adds support for zone/subzone failover settings. For example, failover settings can set as { From: "region1/zone1/subzone1", To: "region2/zone2/subzone2" }

For pepole who only concerns about region-level failover, they can still use failover setting as follow, which compatible with before. { From: "region1", To: "region2" }

This pull request just modify failover releated comments, no proto struct changes.

Related implementation changes resides in this pull request: https://github.com/istio/istio/pull/30781

masquee avatar Feb 18 '21 07:02 masquee

😊 Welcome @masquee! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Feb 18 '21 07:02 istio-policy-bot

Hi @masquee. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 18 '21 07:02 istio-testing

@masquee: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar May 26 '21 20:05 istio-testing

@masquee See a more general way, supporting failover by topology keys

hzxuzhonghu avatar May 27 '21 01:05 hzxuzhonghu

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-05-27. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar May 15 '24 23:05 istio-policy-bot