api icon indicating copy to clipboard operation
api copied to clipboard

Change `http2MaxRequests` setting to `maxRequests`

Open kailun-qin opened this issue 4 years ago • 3 comments

The combination of H1 and H2 conn_pool implementations makes max_requests to work for both H1 and H2 in Envoy proxy (https://github.com/envoyproxy/envoy/issues/9215).

In accordance with this change, this patch updated the field http2MaxRequests of ConnectionPoolSettings.HTTPSettings in DestinationRule API to maxRequests to resolve the outdated H1 only implications/misunderstandings for the field.

Addresses https://github.com/istio/istio/issues/27473

Signed-off-by: Kailun Qin [email protected]

kailun-qin avatar Feb 03 '21 10:02 kailun-qin

😊 Welcome @kailun-qin! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Feb 03 '21 10:02 istio-policy-bot

@kailun-qin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
release-notes_api 903f20c26cf1d6aa30178981f4032613c4fa4ca2 link /test release-notes_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Feb 03 '21 10:02 istio-testing

@kailun-qin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Mar 04 '21 00:03 istio-testing

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-02-03. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar May 15 '24 23:05 istio-policy-bot