api icon indicating copy to clipboard operation
api copied to clipboard

api: add `discovery_service` field to `ProxyConfig`

Open yskopets opened this issue 4 years ago • 4 comments

Signed-off-by: Yaroslav Skopets [email protected]

Summary

  • this PR adds discovery_service field to ProxyConfig
  • part of https://github.com/istio/istio/issues/29108

yskopets avatar Nov 21 '20 22:11 yskopets

😊 Welcome @yskopets! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Nov 21 '20 22:11 istio-policy-bot

/test release-notes_api

yskopets avatar Nov 21 '20 22:11 yskopets

I would suggest instead starting with a doc ( RFC, etc) describing the current distribution mechanism and options for roots of trust, and if we want to make change, have a clear explanation of migration and how the new mechanism should look like. It's too critical change to make directly in the API.

costinm avatar Nov 22 '20 04:11 costinm

@yskopets: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jan 30 '21 21:01 istio-testing

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2020-11-22. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar May 15 '24 23:05 istio-policy-bot