api icon indicating copy to clipboard operation
api copied to clipboard

fix: missing documentation resulting in broken links

Open davidhauck opened this issue 5 years ago • 5 comments

Page does not generate location header properly if it does not have documentation on the package. Added the documentation and generated files

davidhauck avatar Apr 27 '20 22:04 davidhauck

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

istio-policy-bot avatar Apr 27 '20 22:04 istio-policy-bot

Hi @davidhauck. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Apr 27 '20 22:04 istio-testing

/ok-to-test

jasonwzm avatar Apr 30 '20 16:04 jasonwzm

@davidhauck: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jul 24 '20 12:07 istio-testing

@davidhauck: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
gencheck_api 4ce3860f43ff99013e5838a3b08fe18e86834b74 link /test gencheck_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Aug 19 '21 14:08 istio-testing