wasm-extensions icon indicating copy to clipboard operation
wasm-extensions copied to clipboard
verified publisher icon istio-ecosystem

Add wasm-oidc-plugin

Open antonengelhardt opened this issue 2 years ago • 6 comments

Hey there,

i figured it might be useful to include https://github.com/antonengelhardt/wasm-oidc-plugin/ inside this repo. Or are only Wasm Extension written in C++ featured?

Cheers

antonengelhardt avatar Feb 12 '24 18:02 antonengelhardt

No, it's any language, as long as it can be built and tested in CI.

kyessenov avatar Feb 12 '24 20:02 kyessenov

@kyessenov Ok, thanks.

Should i open a PR? And how do you want it to be integrated?

antonengelhardt avatar Feb 12 '24 20:02 antonengelhardt

Yes, you can open a PR. You might need to add a CI step for rust filters specifically, since the base probably doesn't have rust already.

kyessenov avatar Feb 12 '24 20:02 kyessenov

@kyessenov Ok. Does it make sense to add it as a submodule? I have not worked with that before but maybe this makes updating it easier?

antonengelhardt avatar Feb 13 '24 08:02 antonengelhardt

It's easier with a copy I think. If you just want a mention on the docs there, we're happy to link to your repo.

kyessenov avatar Feb 14 '24 00:02 kyessenov

What do you think? https://github.com/istio-ecosystem/wasm-extensions/pull/95

antonengelhardt avatar Feb 14 '24 10:02 antonengelhardt