authservice icon indicating copy to clipboard operation
authservice copied to clipboard

Published 20 hours ago • verified publisher icon istio-ecosystem

refactoring HTTP client

Open Shikugawa opened this issue 3 years ago • 0 comments

Previous HTTP client code has some problems.

  1. It doesn't have transport socket options. So we can't switch raw or tls socket to use in requesting.
  2. Many lines of code are included in the same function. We should separate them.

And also, It has some points to cleanup by @incfly

  • https://github.com/istio-ecosystem/authservice/pull/174#discussion_r733036936
  • https://github.com/istio-ecosystem/authservice/pull/174#discussion_r733038206
  • https://github.com/istio-ecosystem/authservice/pull/174#discussion_r733043346

Shikugawa avatar Oct 21 '21 00:10 Shikugawa