admiral icon indicating copy to clipboard operation
admiral copied to clipboard

[BUG] CRDs are broken in 1.24.x

Open tibers opened this issue 2 years ago • 2 comments

Describe the bug CRDs are broken in k8s version 1.24.x

Steps To Reproduce Attempt to install admiral. At the step $ADMIRAL_HOME/scripts/install_admiral.sh $ADMIRAL_HOME, the installation will fail with error: resource mapping not found for name: "globaltrafficpolicies.admiral.io" namespace: "" from "/Users/tibers/Downloads/admiral-install-v1.2/yaml/remotecluster.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1". This is because CRDs are now apiextensions.k8s.io/v1.

Expected behavior It just works.

Fixing that leads to:

error: error validating "/Users/tibers/Downloads/admiral-install-v1.2/yaml/remotecluster.yaml": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): missing required field "versions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]; if you choose to ignore these errors, turn validation off with --validate=false
namespace/admiral unchanged
error: error validating "/Users/tibers/Downloads/admiral-install-v1.2/yaml/demosinglecluster.yaml": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): missing required field "versions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]; if you choose to ignore these errors, turn validation off with --validate=false

It's extremely likely the whole project needs to be freshened up.

Related: https://github.com/istio-ecosystem/admiral/issues/264

tibers avatar Apr 10 '23 19:04 tibers

Hey @aattuluri A pull request was merged to support Kubernetes version 1.22, but after that, you did not create a new release and did not update this documentation, making it impossible to install Admiral based on this documentation. I think it's a main problem.

ku9nov avatar Feb 02 '24 11:02 ku9nov

@ku9nov: the readme has been updated, can you please try now? @tibers: can you please retry now.

We recently pushed a lot of pending changes to upstream. Please let me know.

nirvanagit avatar Aug 14 '24 00:08 nirvanagit