angular-multi-select icon indicating copy to clipboard operation
angular-multi-select copied to clipboard

Filtering problem when grouped

Open cschwaderer opened this issue 5 years ago • 0 comments

I've found a problem for filtering/searching multi-level grouped input models, so, I changed the if condition in line 182/183

 if ( typeof $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] !== 'undefined'
                            && $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] === false )

into

if (
                           (
                               !$scope.filteredModel[ $scope.filteredModel.length - 1 ]
                               ||
                               typeof $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] !== 'undefined'
                           )
                           &&
                           (
                               !$scope.filteredModel[ $scope.filteredModel.length - 1 ]
                               ||
                               $scope.filteredModel[ $scope.filteredModel.length - 1 ][ attrs.groupProperty ] === false
                           )

That solved the problem for me. I don't see a point in creating a PR, since it seems they are not eagerly pulled right now anyway. However, feel free the use the fix wherever you want!

cschwaderer avatar Apr 04 '19 12:04 cschwaderer