isso icon indicating copy to clipboard operation
isso copied to clipboard

admin: Add log out button

Open BBaoVanC opened this issue 3 years ago • 6 comments

Fixes #552

Adds a logout button to the header, in the top right.

Tasks:

  • [ ] CHANGES.rst

image

BBaoVanC avatar May 08 '22 00:05 BBaoVanC

Wow, the admin CSS is a horrible mess right now. is it better to just do as little change here (like I already have) so it works, and then make another pull request to clean up the CSS?

BBaoVanC avatar Jun 12 '22 19:06 BBaoVanC

Wow, the admin CSS is a horrible mess right now. is it better to just do as little change here (like I already have) so it works, and then make another pull request to clean up the CSS?

Re: Admin CSS: Yes, please open another PR for that and keep this PR focused.

Re: Clearing the cookies: I'm not quite sure whether we need to match SameSite and Secure attributes from server when clearing cookies. Also, IMO we can use a bit more "modern" JS and modern Interfaces such as CookieStore in the admin (just keep the client JS as backward-compatible as possible).

ix5 avatar Jun 13 '22 06:06 ix5

@BBaoVanC would you mind applying the PR feedback? I know it's a bit much to ask, but we should at least try to keep track of SameSite and Secure stuff, I think.

ix5 avatar Jul 06 '22 22:07 ix5

Please rebase this PR after the force-push.

jelmer avatar Aug 04 '23 13:08 jelmer

Please rebase

Done

BBaoVanC avatar Aug 12 '23 00:08 BBaoVanC

Is there anything else this PR needs? I believe when I last looked at it I had already applied @ix5's changes.

BBaoVanC avatar Nov 05 '23 01:11 BBaoVanC