isso icon indicating copy to clipboard operation
isso copied to clipboard

github-action: tests agains 3.11.0-alpha.6

Open fliiiix opened this issue 4 years ago • 1 comments

fliiiix avatar Mar 28 '22 08:03 fliiiix

Nice effort, thanks for doing this. Let's wait for the dependencies to become available for 3.11, keeping this open until then.

See also: 3.11 release schedule

ix5 avatar Mar 28 '22 17:03 ix5

It might make sense to also upgrade the Dockerfile but i could not tst that so its not included

 => ERROR [isso-builder  3/11] RUN python3 -m venv /isso  && . /isso/bin/activate  && pip3 install --no-cache-dir --upgrade pip  && pip3 install --no-cache-dir gu  0.5s

and update the docs build https://github.com/posativ/isso/blob/master/.github/workflows/build-upload-docs.yml#L27

same issue here no idea how to test so i did not upgrade it

But I think this PR is ready to go

fliiiix avatar Oct 29 '22 09:10 fliiiix

Time indeed moves fast... Totally forgot about this. Would you mind pinging me about this on Wednesday?

ix5 avatar Oct 30 '22 19:10 ix5

ping

fliiiix avatar Nov 02 '22 11:11 fliiiix

Please amend the slight wording suggestion, and create a separate commit for the setup.py change.

Otherwise LGTM

ix5 avatar Nov 02 '22 12:11 ix5

I think i addressed all the feedback let me know if there is something else missing to get this merged

fliiiix avatar Nov 03 '22 11:11 fliiiix

Thanks your your contribution and patience!

ix5 avatar Nov 03 '22 14:11 ix5