gomu
gomu copied to clipboard
issadarkthing
Problem regarding cpu usage
I met a problem for both beep and mpd: When open the app, the cup usage for gomu in gotop for mpd is about 2%, and beep is about 20%. After pressing N for like 10 seconds or more (skip), the cup usage for mpd is 40% and beep is 50%, and they don't drop back.
I think it's probably related to the go routine for play. I mean, the player.Run is in go routing, and it never returns, but it will spawn another go routine for next song.
What do you think?
Probably the problem is playingbar running for each song and didn't finish.
I suspect playingbar is the problem. Try disable the playingbar, to see if the problem persists.
Yes, after comment out the content inside playingbar.go:run(), everything seems fine. Probably something wrong inside here.
I think I found the reason. playingbar.skip is never set to true, so the for loop is not ended. When playing, it's not a problem because for loop can be stopped.
Fixed it for now. But I still have too many doubts about this run function.
- Data cannot be fed into go func(). For example, if I move full:=p.getFull before go func, the full length of status bar will not be updated when skip. It's just wired.
- Inside go func, I need access to many data outside, like subtitle or photo, and this create data race which I cannot fix. For int, I could use sync/atomic to avoid data race, but what can I do with pointer?
- The whole block is getting messy but I don't have any clue how to refactor playingbar. Do you have some ideas? Thanks.