TkFontAwesome icon indicating copy to clipboard operation
TkFontAwesome copied to clipboard

Updating to Font Awesome 6

Open jshipley opened this issue 1 year ago • 12 comments

Other than replacing the Font Awesome 5 icons with Font Awesome 6 icons, I did a couple of things

  • Updated the lxml dependency so this will also work on newer versions of Python (fixes issue #5 and #7)
  • Updated the README.md and demo.py screenshot
  • Added support for aliases, so programs using the Font Awesome 5 version will still work
    • This means that fa-basketball, fa-basketball-ball, and basketball will all get the basketball icon
  • Removed duplicate svgs directory, and removed the Font Awesome directories from svgs
    • This would mean that the Font Awesome icons would need to be downloaded again before running consolidate.py, but the most likely case for this would be a Font Awesome update anyway, and this prevents massive diffs when updating the icons
  • Made consolidate.py write to tkfontawesome/svgs.py instead of tkfontawesome/svgs/svgs.py

jshipley avatar Feb 10 '24 19:02 jshipley

I still get the installation error @jshipley

image

DevInfinix avatar Feb 17 '24 16:02 DevInfinix

Is the module still not installable?

avalon60 avatar Feb 17 '24 21:02 avalon60

Is the module still not installable?

for me, it isn't

DevInfinix avatar Feb 17 '24 22:02 DevInfinix

Is the module still not installable?

for me, it isn't

That's a shame. It looked like a game changer for Python Tkinter app icons.

avalon60 avatar Feb 18 '24 10:02 avalon60

I'll take a look at it. I just ran into the same thing yesterday. It's related to the new build isolation feature in Python. See https://github.com/scikit-build/scikit-build/issues/999 for more details.

I'll make an update to the project.toml to address this.

-- Jeff Shipley

On Sat, Feb 17, 2024, at 9:53 AM, INFINIX wrote:

I still get the installation error @jshipley https://github.com/jshipley

image.png (view on web) https://github.com/israel-dryer/TkFontAwesome/assets/72700816/7174feba-2239-4821-babc-b2db58205a91

— Reply to this email directly, view it on GitHub https://github.com/israel-dryer/TkFontAwesome/pull/8#issuecomment-1950254922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFADKDXOTHCWMHBKR5XJDYUDN7LAVCNFSM6AAAAABDC5H5SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGI2TIOJSGI. You are receiving this because you were mentioned.Message ID: @.***>

jshipley avatar Feb 18 '24 16:02 jshipley

I'll take a look at it. I just ran into the same thing yesterday. It's related to the new build isolation feature in Python. See scikit-build/scikit-build#999 for more details. I'll make an update to the project.toml to address this. -- Jeff Shipley On Sat, Feb 17, 2024, at 9:53 AM, INFINIX wrote: I still get the installation error @jshipley https://github.com/jshipley image.png (view on web) https://github.com/israel-dryer/TkFontAwesome/assets/72700816/7174feba-2239-4821-babc-b2db58205a91 — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFADKDXOTHCWMHBKR5XJDYUDN7LAVCNFSM6AAAAABDC5H5SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGI2TIOJSGI. You are receiving this because you were mentioned.Message ID: @.***>

Thanks, much appreciated!

avalon60 avatar Feb 18 '24 16:02 avalon60

I replaced the setup.py and requirements.txt files with a new pyproject.toml file.

It worked for me on python 3.12. Would you mind trying it again?

jshipley avatar Feb 18 '24 17:02 jshipley

I replaced the setup.py and requirements.txt files with a new pyproject.toml file.

It worked for me on python 3.12. Would you mind trying it again?

I have been trying to install via PyPi, but there is no new entry showing? The latest version (0.2), fails using Python 3.12, with:

`Collecting tkfontawesome==0.2.0 Downloading tkfontawesome-0.2.0-py3-none-any.whl (405 kB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 406.0/406.0 kB 2.9 MB/s eta 0:00:00 Collecting lxml==4.7.1 (from tkfontawesome==0.2.0) Downloading lxml-4.7.1.tar.gz (3.2 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.2/3.2 MB 6.7 MB/s eta 0:00:00 Installing build dependencies: started Installing build dependencies: finished with status 'done' Getting requirements to build wheel: started Getting requirements to build wheel: finished with status 'error'

error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully. │ exit code: 1 ╰─> [5 lines of output] :114: SyntaxWarning: invalid escape sequence '.' :67: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html Building lxml version 4.7.1. Building without Cython. Error: Please make sure the libxml2 and libxslt development packages are installed. [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip. error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully. │ exit code: 1 ╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.`

If you would like it testing some other way, please provide instructions.

avalon60 avatar Feb 18 '24 22:02 avalon60

My changes aren't in pypi. So far it's just a pull request that @israel-dryer can merge into the main repository if he wants to.

Unless the PR gets accepted and new version is published to pypi, you're going to have to clone the my fork of the git repository and install it from there.

jshipley avatar Feb 19 '24 00:02 jshipley

My changes aren't in pypi. So far it's just a pull request that @israel-dryer can merge into the main repository if he wants to.

Unless the PR gets accepted and new version is published to pypi, you're going to have to clone the my fork of the git repository and install it from there.

I'll try to take a look this next weekend. Have you considered createing a new repo for this? I am guessing @israel-dryer isn't coming back, unless you know different?

avalon60 avatar Feb 19 '24 18:02 avalon60

Regretfully, I just don't have the capacity to maintain or review these projects anymore. However, I would be more than happy to transfer ownership or add an admin if you are interested in maintaining the project going forward.

israel-dryer avatar Feb 19 '24 18:02 israel-dryer

Is there a way to get the branch produced by @jshipley ?

avalon60 avatar Apr 24 '24 16:04 avalon60

Merge this please! @israel-dryer

Mews avatar Jun 10 '24 09:06 Mews