scrapy-puppeteer icon indicating copy to clipboard operation
scrapy-puppeteer copied to clipboard

Browser manager refactor

Open MatthewZMSU opened this issue 2 months ago • 0 comments

Description

Refactored browser managers so they now do not use syncer and bs4. They do not skip middlewares after PuppeteerServiceDownloaderMiddleware. They do not log useless messages to the console. Temporiraly dropped Pyppeteer support since it is not actively maintained bu the community. Slightly changed CI. Added playwright test spider. Added documentation

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

How Has This Been Tested?

Tested it locally with several scrapy spiders.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

MatthewZMSU avatar Dec 20 '24 11:12 MatthewZMSU