Craig Blanchette

And you'll either need to set the parameter regardless or do: ``` php if (isset($config['flash']) { // ... } else { $container->removeDefinition('mopa_bootstrap.twig.extension.bootstrap_flash'); } ```

Why are you using setting injection? Just add it to the constructor

I mean, there's really no use for a setter here, the twig extension is pretty specific. I would just change the global variable to a function just like the mappings....

He made the changes. Only thing I'm not crazy about is the $close === null part, I think this could be done in twig with a |default()

Yeah I get that, it just seems like an unnecessary thing to put in a getter. Could change it to just be like this: ``` close is null ? mopa_bootstrap_flash_closeable()...

``` {{ flash_messages.flash(mapping[type], message, close|default(mopa_bootstrap_flash_closeable()), use_raw, class, domain) }} ``` or ``` {% set close = close is null ? mopa_bootstrap_flash_closeable() : close %} {{ flash_messages.flash(mapping[type], message, close, use_raw, class,...

I'd still like the weird getter to be fixed and needs a blank line before the return statement to be PSR.

Eh, I don't like that variable passthrough though, I'd rather use `|default` like I suggested above. Plus needs to be rebased anyway so just leave it for now.

It's true, the plugin doesn't know the class of the outlet right now so it can't auto complete the targets of the outlet yet. I only managed to get the...

I can take a look at this soon, and your last issue, unless you want to open a PR for it. Haven't used Symfony in a bit but shouldn't be...