David Strawn

Results 81 comments of David Strawn

Yeah, so in #232 that changes a bit. I changed the underlying hashCode/equals/compare to be based on a `CanonicalFullCaseFoldedString`. There is still some discussion to have there, but all `CanonicalFullCaseFoldedString`...

I hope that makes some amount of sense. Rereading my comment makes me feel like I didn't explain that well. This is what I'm talking about: https://github.com/typelevel/case-insensitive/pull/232/files#diff-90a144a03717314cdaa1151276da76557be0f1e78c890580b57c9d95406f95f6R80

@armanbilge can you make `series/1.x.x` and `series/2.x.x` branches? I don't have access apparently.

Yeah, there are a lot of types in the Unicode standard. For our discussion here we just need to focus on `CanonicalFullCaseFoldedString` and `CIString`. The new encoding of `CIString` on...

@armanbilge @rossabaker let me know what you think

@armanbilge I actually already have the lookup tables: https://github.com/isomarcte/case-insensitive/blob/full-unicode-case-folding/core/src/main/scala/org/typelevel/ci/CaseFolds.scala#L23 It only took a few minutes to get emacs to transform the text file into that. That said, I'm happy to...

I've only poked around in the JRE stdlib. I can check around in JS land to see if we can get a case folded string there and then maybe lighten...

> This would be a semantic breaking change, even if it's binary compatible. If we proceed, should this be 2.0? I'm not sure. It is a semantic change, but most...

@rossabaker @armanbilge take a look here for an ~insane~ alternative approach which handles the different normalization and folding rules more explicitly and doesn't break the semantics of `CIString`.

@ChristopherDavenport I have tests to ensure the `Weigher` is doing what we want, but they won't work unless we expose some of the Caffeine Cache methods, in particular `cleanUp`. That...