Josef Johansson
Josef Johansson
I know. After a while I felt that copying the code is too much, I should work around it instead and leave it as a dependency. If you guys don't...
Obviously I need to rebase the commits. I'll keep the commit history clean though such that it's possible to get a grip on the changes.
I have rebase this towards master, but I still got a ton of changes in go.mod. How do you deal with that generally?
> Not sure what's going on with the new testserver thing, where's that being used? Here: [ By("Generating server binary", func() {](https://github.com/isodude/oauth2-proxy/blob/9c9e10fda9731e29ac5baf642f9edae4c5464555/pkg/http/http_suite_test.go#L90) And in the StandAlone test, since it's hard...
> > And in the StandAlone test, since it's hard to do file descriptor handling with the test suite. > > I'll be honest, this concerns me a bit. Generally...
> perhaps if we put our heads together we can come up with an approach that works This also depends and how much test you would like to have. I...
> > And in the StandAlone test, since it's hard to do file descriptor handling with the test suite. > > I'll be honest, this concerns me a bit. Generally...
> I think this is looking good, though, given the `fd` prefix is case insensitive, we should make sure the test cases cover this. > I did add a test...
@JoelSpeed ping
> MetricsQL already supports numeric sort - see sort_by_label_numeric. This function has been added in v1.82.0 release. See this feature request. Nice, I'll update my query to reflect that!