CppCoreGuidelines icon indicating copy to clipboard operation
CppCoreGuidelines copied to clipboard

the links in I: Interfaces are all broken

Open janwilmans opened this issue 1 year ago • 2 comments

https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#i-interfaces

maybe we should have CI job to check link-integrity?

janwilmans avatar Jul 09 '24 20:07 janwilmans

the intra-document links are intended to be useful here: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#S-interfaces

#2198 fixes the links in github document, though we need to finish reviewing it

cubbimew avatar Jul 10 '24 04:07 cubbimew

the intra-document links are intended to be useful here: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#S-interfaces

#2198 fixes the links in github document, though we need to finish reviewing it

A Python script to automatically check that links and anchors are formatted in CppCoreGuidelines.md using GitHub Actions: github_actions_check_links_py.zip check-links-and-anchors-yml.zip With https://github.com/isocpp/CppCoreGuidelines/commit/50afe0234ce4f2f6bde7d9b0d86e926bd479f9aa modification : CppCoreGuidelines.md

Note :

  • Got a doubt for Rh-public l.376 : (e.g., for C.134 it is "Rh-public")
  • github_actions_check_links.py must be inside scripts/python/

My fork https://github.com/Lob2018/CppCoreGuidelines :

  • The check-link GitHub Actions workflow job works
  • But got error (maybe only update isocpp.dic?) with the make command (-d debug flag added) : https://github.com/Lob2018/CppCoreGuidelines/actions/runs/10847555721/job/30102865071

Lob2018 avatar Sep 12 '24 17:09 Lob2018